wsjtx-2.2.0-rc3 build failure on CentOS 7.8 #install #linux


garylfox@...
 

I just downloaded wsjtx 2.2.0-rc3
I tried compiling on my CentOS 7.8 system and the initial cmake went fine and generated the Makefiles.
When I ran the build command (cmake --build . --target install) it trudged along for quite a while until it got the below error: 
I did not come up with any hints on trying to search for the error message. 
The error seems innocuous, but prevents the build from completing. 
Any know fixes for this? 
Thank you and 73
Gary W2GLF

Generating record_time_signal.moc
[ 88%] Built target record_time_signal_automoc
Scanning dependencies of target wsjt_qtmm_automoc
[ 88%] Automoc for target wsjt_qtmm
Generating moc_BWFFile.cpp
[ 88%] Built target wsjt_qtmm_automoc
Scanning dependencies of target wsjt_qtmm
[ 88%] Building CXX object CMakeFiles/wsjt_qtmm.dir/Audio/BWFFile.cpp.o
/data/apps/wsjtx-2.2.0-rc3/build/wsjtx-prefix/src/wsjtx/Audio/BWFFile.cpp: In constructor ‘{anonymous}::BroadcastAudioExtension::BroadcastAudioExtension({anonymous}::BroadcastAudioExtension::Version)’:
/data/apps/wsjtx-2.2.0-rc3/build/wsjtx-prefix/src/wsjtx/Audio/BWFFile.cpp:83:5: error: parameter ‘version’ set but not used [-Werror=unused-but-set-parameter]
     BroadcastAudioExtension (Version version = Version::v_0)
     ^
cc1plus: all warnings being treated as errors
gmake[6]: *** [CMakeFiles/wsjt_qtmm.dir/Audio/BWFFile.cpp.o] Error 1
gmake[5]: *** [CMakeFiles/wsjt_qtmm.dir/all] Error 2
gmake[4]: *** [all] Error 2
gmake[3]: *** [wsjtx-prefix/src/wsjtx-stamp/wsjtx-build] Error 2
gmake[2]: *** [CMakeFiles/wsjtx-install.dir/all] Error 2
gmake[1]: *** [CMakeFiles/install.dir/rule] Error 2
gmake: *** [install] Error 2


Bill Somerville
 

On 02/06/2020 15:03, garylfox@... wrote:
I just downloaded wsjtx 2.2.0-rc3
I tried compiling on my CentOS 7.8 system and the initial cmake went fine and generated the Makefiles.
When I ran the build command (cmake --build . --target install) it trudged along for quite a while until it got the below error: 
I did not come up with any hints on trying to search for the error message. 
The error seems innocuous, but prevents the build from completing. 
Any know fixes for this? 
Thank you and 73
Gary W2GLF

Hi Gary,

WSJT-X v2.2.0 GA is released as of an hour ago!

I expect you will get the same error which seems to be bogus and only happens with some g++ versions. Use this patch to stop it breaking the build.

73
Bill
G4WJS.

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1e5dd58ba..6778db2c6 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -921,7 +921,7 @@ set (CMAKE_VISIBILITY_INLINES_HIDDEN ON)
 #
 set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra")

-set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror -Wall -Wextra -fexceptions -frtti")
+set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -fexceptions -frtti")

 if (NOT APPLE)
   set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-pragmas")



garylfox@...
 

Well, in the few hours between downloading RC3 and trying to compile it, the GA release became available. 
So I downloaded 2.2.0-GA and found the exact same issue exists with 2.2.0-GA as well. 
Thank you in advance for any help on this. 
73
Gary W2GLF


garylfox@...
 

Thank you Bill, I applied the patch to the CMakeLists.txt file and the build completed successfully (on 2.2.0 GA version). 
Thank you and the team very much for all of your work on this great code! 
Cheers and 73
Gary W2GLF


garylfox@...
 

I had the same issue with 2.2.1-GA, but the same patch fixed it as well.  Just wanted to let you know. 
73
Gary W2GLF


garylfox@...
 

Same for 2.2.2, problem still there, but the patch fixed the issue. 
Will this patch be merged into the next release?